feat: Support Sequential ParExec #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This puts in place support for using a sequential ParExec implementation. This is a first step towards parallelising trace expansion. Specifically, there are two outstanding issues to resolve: firstly, we must be able to add expanded columns in arbitrary order; secondly, we need to actually make `ParExec` operate in parallel (which make require making trace thread-safe or something). The issue around the order in which expanded columns are added to the trace is problematic as the current design essentially expects them to be added in a specific order. Instead, we need assignments and input columns to know what their target column index is. Then, we expanding the trace, they can specify this.
DavePearce
force-pushed
the
260-support-parallel-trace-expansion
branch
from
16e947c to
b9c2786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts in place support for using a sequential ParExec implementation. This is a first step towards parallelising trace expansion. Specifically, there are two outstanding issues to resolve: firstly, we must be able to add expanded columns in arbitrary order; secondly, we need to actually make
ParExecoperate in parallel (which make require making trace thread-safe or something).The issue around the order in which expanded columns are added to the trace is problematic as the current design essentially expects them to be added in a specific order. Instead, we need assignments and input columns to know what their target column index is. Then, we expanding the trace, they can specify this.