Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: remove solcx dependency #3040

Merged
merged 1 commit into from
Jan 21, 2025
Merged

tests: remove solcx dependency #3040

merged 1 commit into from
Jan 21, 2025
+17 −19

Conversation

darwintree
Copy link
Contributor

@darwintree darwintree commented Jan 10, 2025 •
edited by peilun-conflux
Loading

This change is Reviewable

@darwintree darwintree requested a review from Pana January 15, 2025 08:53
Pana
Pana approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@Pana Pana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @darwintree)

Pana
Pana approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@Pana Pana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @darwintree)

@Pana Pana merged commit 22c4a3b into Conflux-Chain:master Jan 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pana Pana Pana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darwintree @Pana