-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from firebase #151
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassemand
reviewed
Dec 4, 2023
lassemand
reviewed
Dec 4, 2023
lassemand
reviewed
Dec 4, 2023
lassemand
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome. Good job and thanks for fast response.
lassemand
reviewed
Dec 4, 2023
lassemand
reviewed
Dec 4, 2023
Co-authored-by: Lasse Alm <[email protected]>
Co-authored-by: Lasse Alm <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR implements the necessary changes required to migrate away from Firebase as we intend to self-host the CCD scan frontend.
Changes
Dockerfile
to./frontend
that will build the image required for custom hosting.README.md
and added a section on how to locally run the Docker image.Jenkinsfile
to build the Docker image similar to the backend. Note: a variable for setting the target environment is required. Additionally, the Docker repository hasn't been added. The flow could be migrated from Jenkin to Github as a Github Action.Checklist
hard-to-understand areas.