Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from firebase #151

Merged
17 commits merged into from
Dec 12, 2023
Merged

Migrate from firebase #151

17 commits merged into from
Dec 12, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 2, 2023

Purpose

This PR implements the necessary changes required to migrate away from Firebase as we intend to self-host the CCD scan frontend.

Changes

  • Added a Dockerfile to ./frontend that will build the image required for custom hosting.
  • Removed Firebase dependencies.
  • Eliminated Firebase references in README.md and added a section on how to locally run the Docker image.
  • Updated the frontend Jenkinsfile to build the Docker image similar to the backend. Note: a variable for setting the target environment is required. Additionally, the Docker repository hasn't been added. The flow could be migrated from Jenkin to Github as a Github Action.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.

@ghost ghost requested a review from lassemand December 2, 2023 09:52
frontend/Dockerfile Outdated Show resolved Hide resolved
frontend/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@lassemand lassemand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome. Good job and thanks for fast response.

frontend/Dockerfile Outdated Show resolved Hide resolved
frontend/Dockerfile Outdated Show resolved Hide resolved
frontend/Dockerfile Outdated Show resolved Hide resolved
@ghost ghost merged commit 72d2b68 into main Dec 12, 2023
1 check passed
@ghost ghost deleted the migrate-from-firebase branch December 12, 2023 10:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant