Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ipfs:// prefix issue #115

Closed
wants to merge 4 commits into from
Closed

Fix ipfs:// prefix issue #115

wants to merge 4 commits into from

Conversation

bogacyigitbasi
Copy link
Contributor

Purpose

Ideally, the browser wallet should not rely on a gateway for IPFS (like https://ipfs.io). The right way is to host the metadata on ipfs:// only without giving any gateways on-chain. Cause when that gateway is down, then you cant access your token, it makes your data centralized in a way.
But when metadata is hosted on IPFS and a token is minted with only the prefix ipfs://Qmsomehash then BW validation checks fail. A ticket is created and when BW addresses this we may change it back, but at the moment this causes confusion in people

Changes

Its a fix for changing "ipfs://" to "https://ipfs.io/ipfs/QmHASH"

_Describe the changes that were needed.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@DOBEN DOBEN mentioned this pull request Jan 16, 2025
@bogacyigitbasi bogacyigitbasi deleted the fix-minting branch January 22, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant