Update package.json & Fix nil value error handling on substring #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated discord.js version
modified: server/events/ready.js
robert4049
changed the title
|
Hi Robert I added your fix, thank you, resolved those errors. But having trouble, it's not showing the highest role in the chat. But from console, I can see it's adding the perms correctly. It's weird, I added the package.json and the discord.js changes, not sure what to think if im not getting more errors. Any ideas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes dependency issues created by the release of discord.js 14.13.0 because their packages are set to automatically grab the latest version of every dependency. An issue was opened in their repo where they stated their solution is to override the dependencies in the package.json. Furthermore, this would not be an issue if FiveM was using a modern instance of node.js and an issue was opened with them to update node.js, so this work around wouldn't be needed in the future. Please note that there's a breaking change in @discordjs/util 1.0.0 with your script and the script will need to be modified prior to updating to 1.0.0
citizenfx/fivem#2166
workaround
discordjs/discord.js#9792