bug fix ipd ionization #5245
Merged
bug fix ipd ionization #5245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikbuibui
reviewed
Jan 8, 2025
| */ | ||
| bool const stateIsUnboundDueToIPDOnly = (ionizationEnergy >= 0._X); | ||
|
|
||
| if(stateIsUnbound && stateIsUnboundDueToIPDOnly) |
There was a problem hiding this comment.
Suggested change
| if(stateIsUnbound && stateIsUnboundDueToIPDOnly) | |
| // state is unbound due to IPD | |
| if(ionizationEnergy >= 0 && ipd > ionizationEnergy) |
EDITED: This might be clearer to read. And we can remove the variables ipdIonizationEnergy, stateIsUnbound, and stateIsUnboundDueToIPDOnly
There was a problem hiding this comment.
I am curious if this is really the logic that is required. What is supposed to happen if ionizationEnergy < 0?
There was a problem hiding this comment.
the state is supposed to relax via the regular time resolved rate solver channels, such as deexcitation, electronic ionization or autonomous ionization(EA).
ci: picongpu
BrianMarre
force-pushed
the
topic-bugFixIPDIonization
branch
from
19518ec to
6eb0d91
Compare
ikbuibui
approved these changes
Jan 9, 2025
chillenzer
added
the
affects latest release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a physics modelling bug causing a non-energy conserving ionization cascade, when encountering non-bound low shell hole states at the start of an atomicPhysics(FLYonPIC) sub step.