Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align file_groupownership_system_commands_dirs with Ubuntu STIGs #13044

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Feb 13, 2025

Description:

  • Modify bash and OVAL to exclude commands that are Set Group ID upon execution (SGID) to align with Ubuntu STIGs

Rationale:

  • Ubuntu STIG rules UBTU-20-010458 and UBTU-22-232055 exclude SGID binaries from the check (and indirectly the remediation)

Modify bash and OVAL to exclude commands that are not Set Group ID
upon execution (SGID) to align with Ubuntu STIGs.
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Feb 13, 2025
Copy link

openshift-ci bot commented Feb 13, 2025

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dodys dodys requested a review from a team February 13, 2025 13:24
@dodys dodys added Ubuntu Ubuntu product related. STIG STIG Benchmark related. labels Feb 13, 2025
@dodys dodys added this to the 0.1.77 milestone Feb 13, 2025
@dodys dodys self-assigned this Feb 13, 2025
@dodys dodys modified the milestones: 0.1.77, 0.1.76 Feb 13, 2025
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 616d436 into ComplianceAsCode:stabilization-v0.1.76 Feb 14, 2025
93 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants