Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ensure_redhat_gpgkey_installed on RHEL 10 #12767

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

jan-cerny
Copy link
Collaborator

We have discovered during productization that the rule ensure_redhat_gpgkey_installed fails on RHEL 10.
It seems to have an easy fix so we aren't opening a ticket but we are fixing it directly.
The release and version values in product.yml were swapped.

[root@XXX ~]# rpm -q redhat-release
redhat-release-10.0-24.el10.x86_64
[root@XXX ~]# rpm -q --queryformat 'release=%{RELEASE} version=%{VERSION}\n' gpg-pubkey
release=4ae0493b version=fd431d51
release=6229229e version=5a6340b3

We have discovered during productization that the rule
ensure_redhat_gpgkey_installed fails on RHEL 10.
It seems to have an easy fix so we aren't opening a ticket
but we are fixing it directly.
The release and version values in product.yml were swapped.

```
[root@XXX ~]# rpm -q redhat-release
redhat-release-10.0-24.el10.x86_64
[root@XXX ~]# rpm -q --queryformat 'release=%{RELEASE} version=%{VERSION}\n' gpg-pubkey
release=4ae0493b version=fd431d51
release=6229229e version=5a6340b3
```
@jan-cerny jan-cerny added productization-issue Issue found in upstream stabilization process. RHEL10 Red Hat Enterprise Linux 10 product related. labels Jan 2, 2025
@jan-cerny jan-cerny added this to the 0.1.76 milestone Jan 2, 2025
Copy link

github-actions bot commented Jan 2, 2025

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Jan 2, 2025

Code Climate has analyzed commit 00fe29b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.6% (0.0% change).

View more on Code Climate.

@matusmarhefka matusmarhefka self-assigned this Jan 3, 2025
@matusmarhefka matusmarhefka merged commit 038e629 into ComplianceAsCode:master Jan 3, 2025
105 checks passed
jan-cerny added a commit to jan-cerny/scap-security-guide that referenced this pull request Jan 10, 2025
The PR ComplianceAsCode#12767 fixed the swap of pkg_relase and pkg_version, but unfortunately,
it hasn't fixed the typo in the pkg_release, so we will fix it now.
@jan-cerny jan-cerny mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
productization-issue Issue found in upstream stabilization process. RHEL10 Red Hat Enterprise Linux 10 product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants