Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ccn profile to OL9 #12759

Merged
merged 2 commits into from
Dec 21, 2024
Merged

Add ccn profile to OL9 #12759

merged 2 commits into from
Dec 21, 2024

Conversation

mrkanon
Copy link
Contributor

@mrkanon mrkanon commented Dec 20, 2024

Description:

  • Create CCN profile for ol9

Rationale:

  • Missing profile in OL9

Signed-off-by: Armando Acosta <[email protected]>
@mrkanon mrkanon requested a review from a team as a code owner December 20, 2024 20:04
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 20, 2024
Copy link

openshift-ci bot commented Dec 20, 2024

Hi @mrkanon. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 added this to the 0.1.76 milestone Dec 20, 2024
@Mab879 Mab879 added Oracle Linux Oracle Linux product related. New Profile Issues or pull requests related to new Profiles. labels Dec 20, 2024
@Xeicker
Copy link
Contributor

Xeicker commented Dec 20, 2024

There is one test failing about product stability.
You'll need to update this info by running:

tests/test_product_stability.py --update-reference-data products/ tests/data/product_stability/

And ensure the change only includes what you updated for OL9 product

Copy link

codeclimate bot commented Dec 20, 2024

Code Climate has analyzed commit 96ebb50 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.6% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@Xeicker Xeicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xeicker Xeicker self-assigned this Dec 21, 2024
@Xeicker Xeicker merged commit 48b34af into ComplianceAsCode:master Dec 21, 2024
98 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. New Profile Issues or pull requests related to new Profiles. Oracle Linux Oracle Linux product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants