Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubuntu 24.04 5.4.2.4 Ensure root account access is controlled #12672

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Ubuntu 24.04 5.4.2.4 Ensure root account access is controlled #12672

merged 3 commits into from
Dec 16, 2024

Conversation

ericeberry
Copy link
Contributor

Description:

  • Ubuntu 24.04 5.4.2.4 Ensure root account access is controlled

Rationale:

  • Implements Ubuntu 24.04 5.4.2.4

@ericeberry ericeberry requested a review from a team as a code owner December 4, 2024 22:44
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 4, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 4, 2024

Hi @ericeberry. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ericeberry ericeberry changed the title Ubuntu 22.04 5.4.2.4 Ensure root account access is controlled Ubuntu 24.04 5.4.2.4 Ensure root account access is controlled Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2404 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@dodys dodys self-assigned this Dec 5, 2024
@dodys dodys added Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. labels Dec 5, 2024
@dodys dodys added this to the 0.1.76 milestone Dec 5, 2024
mpurg
mpurg suggested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor review

controls/cis_ubuntu2404.yml Outdated Show resolved Hide resolved
mpurg
mpurg reviewed Dec 5, 2024
View reviewed changes
controls/cis_ubuntu2404.yml Outdated Show resolved Hide resolved
mpurg
mpurg approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ericeberry ericeberry requested a review from a team as a code owner December 10, 2024 15:41
mpurg
mpurg suggested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline needed

...ide/system/accounts/accounts-restrictions/root_logins/ensure_root_access_controlled/rule.yml Outdated Show resolved Hide resolved
@dodys dodys removed the request for review from a team December 12, 2024 08:38
@dodys
Copy link
Contributor

dodys commented Dec 12, 2024

/packit build

@Mab879
Copy link
Member

Mab879 commented Dec 12, 2024

Just an FYI, you still need to correct line ending in linux_os/guide/system/accounts/accounts-restrictions/root_logins/ensure_root_access_controlled/rule.yml

@ericeberry
Copy link
Contributor Author

Just an FYI, you still need to correct line ending in linux_os/guide/system/accounts/accounts-restrictions/root_logins/ensure_root_access_controlled/rule.yml

Hopefully fixed this time

@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 12, 2024

Code Climate has analyzed commit cf3f734 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member

Mab879 commented Dec 12, 2024

Just an FYI, you still need to correct line ending in linux_os/guide/system/accounts/accounts-restrictions/root_logins/ensure_root_access_controlled/rule.yml

Hopefully fixed this time

That seems to have done it.

Thanks!

@dodys
Copy link
Contributor

dodys commented Dec 16, 2024

/packit build

dodys
dodys approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 8a725ff into ComplianceAsCode:master Dec 16, 2024
93 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpurg mpurg mpurg requested changes

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.76
Development

Successfully merging this pull request may close these issues.
4 participants
@ericeberry @dodys @Mab879 @mpurg