Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firewall technology related rules per service and package change logic according to interactive profile variable #11818
Firewall technology related rules per service and package change logic according to interactive profile variable #11818
Changes from 16 commits
b49f4ce
660e7f8
dc4a098
64885fd
9aa0beb
22ac8fd
99243ab
3a65275
93fc615
53f09ca
55fd107
67b3616
7df2ff6
75126ba
e8ef4d7
6ae92ca
8f0fdfe
55f0f79
b7a296e
b96d658
440dd03
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@teacup-on-rockingchair I think the operation here should be flipped.
The implementation searches for VARIABLE regex inside VALUE, instead of searching for VALUE regex in VARIABLE.
If
VALUE=firewalld|nftables
, then it will match whenVARIABLE
is set to any substring of VALUE, or an empty string, or regex special characters like.
.