Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

places SELECT buttons to the left side #10

Merged
merged 5 commits into from
Mar 9, 2024

Conversation

K2adir
Copy link
Contributor

@K2adir K2adir commented Mar 8, 2024

This Tailwind edit places the select button on the left side, allowing users to easily read and select the missing models. Previously, the UI placed the select button to the right, making it hard to recognize which select button belongs to the available module, especially on wide screens.

Before:
Screenshot 2024-03-07 at 7 01 41 PM

after
Screenshot 2024-03-07 at 7 01 56 PM

Note: I didn't make any changes on the index.tsx, prettier changed it's formatting

this tailwind edit, places the select button on the left side so the user can read and select the missing models easily. Before, the UI placed the select button on the all the way to the right, which makes it hard to recognize which select button belongs to the avalible module. Especially on wide screens.
@K2adir
Copy link
Contributor Author

K2adir commented Mar 8, 2024

Not sure why Prettier changed the formatting this much. Perhaps, the project is missing prettier configs?

@thecooltechguy
Copy link
Contributor

Thanks for this PR @K2adir ! Will review + merge this.

Also, we don't yet have any prettier configs setup haha, will look into it.
If you have any recommended prettier configs, would love to know!

@thecooltechguy
Copy link
Contributor

@K2adir I just added some prettier configs to the web/ folder in the main branch, can you kindly push another commit that runs the prettier formatter in your version of the web/ folder, which should resolve all conflicts?

thanks!

@K2adir
Copy link
Contributor Author

K2adir commented Mar 8, 2024

@K2adir I just added some prettier configs to the web/ folder in the main branch, can you kindly push another commit that runs the prettier formatter in your version of the web/ folder, which should resolve all conflicts?

thanks!

sure! on it

@dylanintech
Copy link
Contributor

dylanintech commented Mar 9, 2024

hey @K2adir - we're going to review this PR as soon as possible, we've just been super busy with fixing docker installation on windows (#9, #8). thank you for your contribution and patience - your edit actually makes sense.

@thecooltechguy thecooltechguy merged commit ed01fba into ComfyWorkflows:main Mar 9, 2024
1 check failed
@thecooltechguy
Copy link
Contributor

Thanks for this PR @K2adir , just merged! :)

thecooltechguy added a commit that referenced this pull request Mar 11, 2024
places SELECT buttons to the left side
thecooltechguy added a commit that referenced this pull request Mar 11, 2024
places SELECT buttons to the left side
thecooltechguy added a commit that referenced this pull request Mar 11, 2024
places SELECT buttons to the left side
thecooltechguy added a commit that referenced this pull request Mar 11, 2024
places SELECT buttons to the left side
thecooltechguy added a commit that referenced this pull request Mar 11, 2024
places SELECT buttons to the left side
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants