-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N°3777 - favicon: change easily favicon #619
base: develop
Are you sure you want to change the base?
Conversation
What about themes? They are defined under the |
core/config.class.inc.php
Outdated
'app_icon_url' => [ | ||
'branding_environment' => [ | ||
'type' => 'string', | ||
'description' => 'type of branding. usefull for put different logo depending environment', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo (useful)
Mind that favicon might not be a single file |
Workshop planned to discuss the fields. |
b3ce823
to
27022ed
Compare
Has this been discussed? |
With Vincent & Ben, we discussed the new XML. I need to change the description. I do it whenever I have some time. The current nodes do not change. we just add new ones. |
Allow customization of favicon and logo depending on environment:
define them in XML first:
and then you can choose different favicon and logo using the configuration file:
// branding_environment: type of branding. usefull for put different logo depending environment
'branding_environment' => 'test',
( portal favicon can also be customized in module_design:
)