use email when firstname or lastname not provided by IdP + ci tests o…

…n top of itop 3.2
Combodo · Jan 20, 2025 · dc9f272 · dc9f272
1 parent fd89142
commit dc9f272
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/HybridAuthLoginExtension.php b/src/HybridAuthLoginExtension.php
@@ -348,8 +348,8 @@ private function DoUserProvisioning(string $sLoginMode)
 				}
 
 				// Create the person
-				$sFirstName = $oUserProfile->firstName;
-				$sLastName = $oUserProfile->lastName;
+				$sFirstName = $oUserProfile->firstName ?? $sEmail;
+				$sLastName = $oUserProfile->lastName ?? $sEmail;
 				$sOrganization = Config::GetDefaultOrg($sLoginMode);
 				$aAdditionalParams = array('phone' => $oUserProfile->phone);
 				IssueLog::Info("OpenID Person provisioning", HybridAuthLoginExtension::LOG_CHANNEL,

diff --git a/tests/ci_description.ini b/tests/ci_description.ini
@@ -4,7 +4,7 @@
 
 [itop]
 ;itop_branch: when not provided by default develop.
-itop_branch=support/3.1
+itop_branch=support/3.2
 
 ;itop_target_uri: use to launch ci from a factory target
 ;itop_target_uri="type=build&item=iTop%20Professional&version=3.1.2"