Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance #317

Merged
merged 2 commits into from
Mar 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
// https://github.com/microsoft/vscode-dev-containers/tree/v0.195.0/containers/javascript-node
{
"name": "Docusaurus",
// Update 'VARIANT' to pick a Node version: 16, 14, 12.
// Append -bullseye or -buster to pin to an OS version.
// Use -bullseye variants on local arm64/Apple Silicon.
"image": "mcr.microsoft.com/devcontainers/javascript-node",

// Configure tool-specific properties.
Expand All @@ -19,8 +16,8 @@
"editor.rulers": [100],
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true,
"source.fixAll.markdownlint": true
"source.fixAll.eslint": "always",
"source.fixAll.markdownlint": "always"
},
"eslint.options": {
"extensions": [".js", ".jsx", ".md", ".mdx", ".ts", ".tsx"]
Expand Down Expand Up @@ -59,7 +56,10 @@
// Use 'forwardPorts' to make a list of ports inside the container available locally.
"forwardPorts": [3000],

// Use 'postCreateCommand' to run commands after the container is created.
// Use 'updateContentCommand' to run commands after the container is created and before the project is cloned.
"updateContentCommand": "npm install -g npm",

// Use 'postCreateCommand' to run commands after the project has been cloned into the container.
"postCreateCommand": "npm install",

// Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@ jobs:
- name: Build
id: build
run: |
npm install -g npm
npm install
npm run build --if-present
npm run build

- name: Deploy
if: steps.build.outcome == 'success' && github.ref == 'refs/heads/main' && !contains(github.event.head_commit.message, 'skip deploy')
Expand Down
12 changes: 7 additions & 5 deletions docs/eln/install_configure/configuration.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -447,11 +447,13 @@ production:

Here the `nmriumwrapper.url` value depends on the version of Chemotion ELN you are using. The compatibility between the ELN and the wrapper is as follows:

| Version of Chemotion ELN | Version of NMRium wrapper |
| ------------------------ | ------------------------- |
| 1.5 & 1.6 | 0.1.0 |
| 1.7.0 - 1.7.2 | 0.1.0 - 0.3.0 |
| 1.7.3 | 0.4.0 |
| Version of Chemotion ELN | Version(s) of NMRium wrapper |
| ------------------------ | ---------------------------- |
| 1.5 & 1.6 | 0.1.0 |
| 1.7.0 - 1.7.2 | 0.1.0 - 0.3.0 |
| 1.7.3 - 1.8.1 | 0.4.0 |
| 1.8.2 | 0.5.0 |
| 1.9.0 | 0.4.0 - 0.6.0 |

So, if you are using e.g. ELN version 1.5.3, please `nmriumwrapper.url` to `https://nmrium.nmrxiv.org/releases/v0.1.0/`.

Expand Down
2 changes: 0 additions & 2 deletions src/js/gallery.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ export function Gallery({ links, titles }) {
width="320"
height="180"
src={link}
// title={this.state.titles[idx]}
frameBorder="0"
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture"
allowFullScreen
/>
Expand Down