Fix feature documentation and keywords + bump version number #86
Clippy Output
12 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 12 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.75.0 (82e1608df 2023-12-21)
- cargo 1.75.0 (1d8b05cdd 2023-11-20)
- clippy 0.1.75 (82e1608 2023-12-21)
Annotations
Check warning on line 425 in src/sop/optim/sat.rs
github-actions / Clippy Output
the loop variable `i` is only used to index `vars`
warning: the loop variable `i` is only used to index `vars`
--> src/sop/optim/sat.rs:425:18
|
425 | for i in 1..vars.len() {
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator
|
425 | for <item> in vars.iter().skip(1) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~~
Check warning on line 423 in src/sop/optim/sat.rs
github-actions / Clippy Output
length comparison to one
warning: length comparison to one
--> src/sop/optim/sat.rs:423:17
|
423 | assert!(vars.len() >= 1);
| ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!vars.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
Check warning on line 10 in src/sop.rs
github-actions / Clippy Output
module has the same name as its containing module
warning: module has the same name as its containing module
--> src/sop.rs:10:1
|
10 | mod sop;
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
Check warning on line 105 in src/sop/ecube.rs
github-actions / Clippy Output
unneeded `return` statement
warning: unneeded `return` statement
--> src/sop/ecube.rs:105:9
|
105 | return true;
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
105 - return true;
105 + true
|
Check warning on line 90 in src/sop/ecube.rs
github-actions / Clippy Output
unneeded `return` statement
warning: unneeded `return` statement
--> src/sop/ecube.rs:90:9
|
90 | return max(self.num_lits(), 1) - 1;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
90 - return max(self.num_lits(), 1) - 1;
90 + max(self.num_lits(), 1) - 1
|
Check warning on line 149 in src/sop/cube.rs
github-actions / Clippy Output
unneeded `return` statement
warning: unneeded `return` statement
--> src/sop/cube.rs:149:9
|
149 | return true;
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
149 - return true;
149 + true
|
Check warning on line 119 in src/sop/cube.rs
github-actions / Clippy Output
unneeded `return` statement
warning: unneeded `return` statement
--> src/sop/cube.rs:119:9
|
119 | return max(self.num_lits(), 1) - 1;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
119 - return max(self.num_lits(), 1) - 1;
119 + max(self.num_lits(), 1) - 1
|
Check warning on line 272 in src/canonization.rs
github-actions / Clippy Output
the loop variable `i` is used to index `res_perm`
warning: the loop variable `i` is used to index `res_perm`
--> src/canonization.rs:272:14
|
272 | for i in 0..res_perm.len() {
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator and enumerate()
|
272 | for (i, <item>) in res_perm.iter_mut().enumerate() {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Check warning on line 233 in src/canonization.rs
github-actions / Clippy Output
the variable `ind` is used as a loop counter
warning: the variable `ind` is used as a loop counter
--> src/canonization.rs:233:5
|
233 | for swap in all_swaps {
| ^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (ind, swap) in all_swaps.iter().enumerate()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
Check warning on line 229 in src/canonization.rs
github-actions / Clippy Output
the loop variable `i` is used to index `res_perm`
warning: the loop variable `i` is used to index `res_perm`
--> src/canonization.rs:229:14
|
229 | for i in 0..res_perm.len() {
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator and enumerate()
|
229 | for (i, <item>) in res_perm.iter_mut().enumerate() {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Check warning on line 163 in src/canonization.rs
github-actions / Clippy Output
the variable `ind` is used as a loop counter
warning: the variable `ind` is used as a loop counter
--> src/canonization.rs:163:5
|
163 | for swap in all_swaps {
| ^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (ind, swap) in all_swaps.iter().enumerate()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
= note: `#[warn(clippy::explicit_counter_loop)]` on by default
Check warning on line 117 in src/canonization.rs
github-actions / Clippy Output
the loop variable `i` is used to index `all_perms`
warning: the loop variable `i` is used to index `all_perms`
--> src/canonization.rs:117:18
|
117 | for i in 0..all_perms.len() {
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator and enumerate()
|
117 | for (i, <item>) in all_perms.iter().enumerate() {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~