Change representation of the cubes to better handle values #43
Clippy Output
7 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 7 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.74.1 (a28077b28 2023-12-04)
- cargo 1.74.1 (ecb9851af 2023-10-18)
- clippy 0.1.74 (a28077b 2023-12-04)
Annotations
Check warning on line 621 in src/static_lut.rs
github-actions / Clippy Output
casting to the same type is unnecessary (`u64` -> `u64`)
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> src/static_lut.rs:621:29
|
621 | Lut6::from_blocks(&[table as u64])
| ^^^^^^^^^^^^ help: try: `table`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
Check warning on line 272 in src/canonization.rs
github-actions / Clippy Output
the loop variable `i` is used to index `res_perm`
warning: the loop variable `i` is used to index `res_perm`
--> src/canonization.rs:272:14
|
272 | for i in 0..res_perm.len() {
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator and enumerate()
|
272 | for (i, <item>) in res_perm.iter_mut().enumerate() {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Check warning on line 233 in src/canonization.rs
github-actions / Clippy Output
the variable `ind` is used as a loop counter
warning: the variable `ind` is used as a loop counter
--> src/canonization.rs:233:5
|
233 | for swap in all_swaps {
| ^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (ind, swap) in all_swaps.iter().enumerate()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
Check warning on line 229 in src/canonization.rs
github-actions / Clippy Output
the loop variable `i` is used to index `res_perm`
warning: the loop variable `i` is used to index `res_perm`
--> src/canonization.rs:229:14
|
229 | for i in 0..res_perm.len() {
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator and enumerate()
|
229 | for (i, <item>) in res_perm.iter_mut().enumerate() {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Check warning on line 163 in src/canonization.rs
github-actions / Clippy Output
the variable `ind` is used as a loop counter
warning: the variable `ind` is used as a loop counter
--> src/canonization.rs:163:5
|
163 | for swap in all_swaps {
| ^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (ind, swap) in all_swaps.iter().enumerate()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
= note: `#[warn(clippy::explicit_counter_loop)]` on by default
Check warning on line 117 in src/canonization.rs
github-actions / Clippy Output
the loop variable `i` is used to index `all_perms`
warning: the loop variable `i` is used to index `all_perms`
--> src/canonization.rs:117:18
|
117 | for i in 0..all_perms.len() {
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator and enumerate()
|
117 | for (i, <item>) in all_perms.iter().enumerate() {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Check warning on line 230 in src/sop.rs
github-actions / Clippy Output
associated items `simplify`, `not`, `or`, and `and` are never used
warning: associated items `simplify`, `not`, `or`, and `and` are never used
--> src/sop.rs:230:8
|
184 | impl Sop {
| -------- associated items in this implementation
...
230 | fn simplify(&mut self) {
| ^^^^^^^^
...
237 | fn not(&self) -> Sop {
| ^^^
...
242 | fn or(a: &Sop, b: &Sop) -> Sop {
| ^^
...
249 | fn and(a: &Sop, b: &Sop) -> Sop {
| ^^^
|
= note: `#[warn(dead_code)]` on by default