Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CU-8693ftbyx: Make GH pre-release tag apply for PyPI #389

Closed
wants to merge 14 commits into from
Closed

CU-8693ftbyx: Make GH pre-release tag apply for PyPI #389

wants to merge 14 commits into from

Conversation

mart-r
Copy link
Collaborator

@mart-r mart-r commented Jan 8, 2024

Currently when drafting a release on GitHub and marking it as a pre-release, it gets sent to PyPI as a full release rather than a pre-release.

This PR attempts to fix that by

  • Checking if the release is a pre-release
  • If it is, pass it on to PyPI as such

PS:
I don't really know how to test the change. I just put it together from example online.

@tomolopolis
Copy link
Member

Task linked: CU-8693ftbyx GitHub pre-releases appear as regular releases in pypi

mart-r added 9 commits January 9, 2024 14:51
@mart-r
CU-8693ftbyx: Add pre-release type release testing to main workflow
04f6a8e
@mart-r
CU-8693ftbyx: [TEMP] Allow publish to test-pypi outside master branch
a25c784
@mart-r
CU-8693ftbyx: [TEMP] Allow publish to test-pypi outside master branch #2
80e6b5b
@mart-r
CU-8693ftbyx: [TEMP] Allow publish to test-pypi outside master branch #3
07512f8
@mart-r
CU-8693ftbyx: Remove pre-release tag from the build command
85d08c8
@mart-r
CU-8693ftbyx: Remove pre-release tag from the build command (production)
081228b
@mart-r
Revert "CU-8693ftbyx: [TEMP] Allow publish to test-pypi outside maste…
0bc0278 
…r branch #3"

This reverts commit 07512f8.
@mart-r
Revert "CU-8693ftbyx: [TEMP] Allow publish to test-pypi outside maste…
bf3032d 
…r branch #2"

This reverts commit 80e6b5b.
@mart-r
Revert "CU-8693ftbyx: [TEMP] Allow publish to test-pypi outside maste…
c4740f6 
…r branch"

This reverts commit a25c784.
baixiac
baixiac approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@baixiac baixiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM and one minor comment.

.github/workflows/main.yml Outdated
# The idea is that if the pre-release works, so does the regular release.
# The other option would be to run for pre-release and regular release
# but the trivial version for that would duplicate a bunch of the YAML.
run: echo ::set-output name=is_prerelease::true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The set-output has been deprecated so pls consider using other options such as GITHUB_ENV. The same applies to line 96.

@mart-r
Copy link
Collaborator Author

mart-r commented Jan 15, 2024

This does not do anything.
As per the action:
https://github.com/CogStack/MedCAT/actions/runs/7464041795/job/20310539426

Warning: Unexpected input(s) 'prerelease', valid inputs are ['entryPoint', 'args', 'user', 'password', 'repository_url', 'packages_dir', 'verify_metadata', 'skip_existing', 'verbose']

@mart-r mart-r closed this Jan 15, 2024
@mart-r mart-r deleted the CU-8693ftbyx-prod-4-pre-release branch August 12, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baixiac baixiac baixiac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mart-r @tomolopolis @baixiac