Skip to content
This repository has been archived by the owner on Jan 14, 2024. It is now read-only.

Remove unvaluable exercises #464

Merged
merged 8 commits into from
Dec 7, 2022
Merged

Conversation

Dedekind561
Copy link
Contributor

@Dedekind561 Dedekind561 commented Dec 5, 2022

Changes

Part of review from here CodeYourFuture/syllabus#499

  • Removes old exercises dir - exercises in there are really trivial and the syllabus lesson exercises already assess those basic skills anyway so seems pointless to do it twice.
  • Also removes reference to + operator in strings to encourage trainees to use template literals from the get-go
  • Updates language wrt TDD. We're currently not using TDD to check their work. We're using tests that were written outside the TDD red-green-refactor cycle. It doesn't make sense to refer to TDD here.

Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This following comment is not blocking for these changes.

I agree these exercises are not good value. The practice is good for some trainees, however, so how about linking them to some exercise lists as a resource in the coursework instead?

Possibilities:

https://exercism.org/tracks/javascript/exercises
https://www.jschallenger.com/javascript-basics
https://www.executeprogram.com/courses/javascript-array/lessons/basics

Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@Dedekind561 Dedekind561 merged commit 09f2e55 into master Dec 7, 2022
@Dedekind561 Dedekind561 deleted the remove-unvaluable-exercises branch December 7, 2022 09:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants