add support for toggling line numbers on and off #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-p-commits
commented
Jan 23, 2023
ben-p-commits
commented
Jan 23, 2023
|
Should we also shift all content to the left when the line numbers are hidden? Is the space the line numbers were consuming not necessary anymore? It looks like Xcode does this... Screen.Recording.2023-01-23.at.4.40.13.PM.mov |
|
@austincondiff - ooh okay, i'll see what I can do |
|
Update: created a PR over in STTextView to enable this behavior without introducing code smell in CETV... @austincondiff - if we can get that change approved: we get the improved behavior: hide-rulers.mp4 |
|
@ben-p-commits Ok lets wait for the outcome of the PR on |
|
@lukepistrol, closing this in light of #127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for #115, ✨Option To Hide Line Numbers. Simply shows/hides ruler view. should be easy enough in the future to include affordances for enabling/disabling code folding ribbon, code review, other rulerview utilities once they come into play.
Demo