Add -skipcrossarchnative and -verbose options (dotnet#90554)

* Add CoreclrVerbose=true when --verbose is passed as option to build.sh Sponsored by: Tekvox Inc. Cc: Jim Reinhart <[email protected]> Cc: James Autry <[email protected]> Cc: Matthew Maron <[email protected]> Signed-off-by: Giulio Benetti <[email protected]> * Remove leftover comment about -skipcrossarchnative During commit 7d562f9 comment about -skipcrossarchnative has been forgotten, so let's remove it since that flag is not available anymore. Signed-off-by: Giulio Benetti <[email protected]> * Correct shift value --------- Signed-off-by: Giulio Benetti <[email protected]> Co-authored-by: Giulio Benetti <[email protected]> Co-authored-by: Juan Hoyos <[email protected]>
CodeBlanch · Oct 5, 2023 · 0e8523e · 0e8523e
1 parent 55be11c
commit 0e8523e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/eng/build.sh b/eng/build.sh
@@ -524,6 +524,11 @@ while [[ $# > 0 ]]; do
       shift 2
       ;;
 
+      -verbose)
+      arguments="$arguments /p:CoreclrVerbose=true"
+      shift 1
+      ;;
+
       *)
       extraargs="$extraargs $1"
       shift 1

diff --git a/src/coreclr/build-runtime.sh b/src/coreclr/build-runtime.sh
@@ -20,7 +20,6 @@ export PYTHON
 
 usage_list+=("-pgodatapath: path to profile guided optimization data.")
 usage_list+=("-pgoinstrument: generate instrumented code for profile guided optimization enabled binaries.")
-usage_list+=("-skipcrossarchnative: Skip building cross-architecture native binaries.")
 usage_list+=("-staticanalyzer: use scan_build static analyzer.")
 usage_list+=("-component: Build individual components instead of the full project. Available options are 'hosts', 'jit', 'runtime', 'paltests', 'alljits', 'iltools', 'nativeaot', and 'spmi'. Can be specified multiple times.")
 usage_list+=("-subdir: Append a directory with the provided name to the obj and bin paths.")

diff --git a/src/coreclr/runtime.proj b/src/coreclr/runtime.proj
@@ -33,6 +33,7 @@
       <_CoreClrBuildArg Condition="'$(PortableBuild)' != 'true'" Include="-portablebuild=false" />
       <_CoreClrBuildArg Condition="'$(KeepNativeSymbols)' != 'false'" Include="-keepnativesymbols" />
       <_CoreClrBuildArg Include="-os $(_BuildNativeTargetOS)" />
+      <_CoreClrBuildArg Condition="'$(CoreclrVerbose)' == 'true'" Include="-verbose" />
 
       <_CoreClrBuildArg Condition="$([MSBuild]::IsOsPlatform(Windows)) and
                                    ('$(TargetArchitecture)' == 'x86' or '$(TargetArchitecture)' == 'x64') and
-Original file line number
+Diff line change
@@ Expand Up / @@ -524,6 +524,11 @@ while [[ $# > 0 ]]; do @@
           shift 2
           ;;
+          -verbose)
+          arguments="$arguments /p:CoreclrVerbose=true"
+          shift 1
+          ;;
           *)
           extraargs="$extraargs $1"
           shift 1
@@ Expand Down @@