GI-11 Match Dropdown to Figma #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahekagg
approved these changes
Oct 11, 2023
hams7504
added a commit
that referenced
this pull request
Oct 20, 2023
* intial commit * initial commit * started sample map * map loads 0726 * added boundary feature and restrictions * map renders without api key in index file * WIP * cleaned up the code * revert changes to monarch * remove whitespace * removed marker * added comments * WIP * WIP * added marker functionality * added constants file * search box * removed ts-ignore + fixed errors * removed ts-ignore + fixed errors * fixed lint errors * added places library to loader * added setup instructions to readme * added setup instructions to readme * added gi locations for markers * initial commit * added divider and about * added header and MapLegend component * added header * fixed double map * WIP * fixed positioning * created legend icons array * added checkboxes and site type icons * created map page * create popup box * completed navbar * removed unnecessary functions * code cleanup * addressed comments * popup box renders for all markers * finished styling popup box * Revert "Hm popup box" * fix page * WIP * file name update * fixed * fixed popup box * fixed styling * fixed styling * added image files * created selectable buttons and attempted collapse * working on collapse * add sites from google sheets * icons * added site types * add custom icons * filtering works for feature types! * filtering by feature type * everything but font' * revert accidental main commit * WIP * GI-5 Make legend box fully collapsible (#46) * collapsible legend, not great styling * button within same component, no size flicker * removed empty tag render * change appbar position type (#39) * 37 gi 6 make search box customizable (#47) * Comment out links to the events and FAQ pages in the footer (#34) * change searchbox dimensions + rounded corners * Changed font * resolve merge, revert footer --------- Co-authored-by: Kenny Jung <[email protected]> Co-authored-by: “airman416” <“[email protected]”> Co-authored-by: Hamsini Malli <[email protected]> * add sites + filtering by status & feature works * repositioned map icons * restored collapsible box * ui changes in progress * updated icons * cleaned code * meeting changes (#52) Co-authored-by: David Li <[email protected]> * GI-9 Add sign up / login buttons and profile icon button (#51) * stash changes before merge * update styling * remove comments * GI-10 add checkboxes next to "Available" / "Adopted" (#56) * status checkboxes * remove unused comments * update styling * remove unused arg * change checkbox color * Removed import --------- Co-authored-by: “airman416” <“[email protected]”> * GI-10 Add "Available"/"Adopted" checkboxes (v2) (#57) * status checkboxes * remove unused comments * update styling * remove unused arg * change checkbox color * Removed import * revert version * actually fixed fr --------- Co-authored-by: “airman416” <“[email protected]”> * Revert "GI-10 Add "Available"/"Adopted" checkboxes (v2) (#57)" This reverts commit bbaa240. * Revert "GI-10 add checkboxes next to "Available" / "Adopted" (#56)" This reverts commit e19c03f. * Revert "GI-9 Add sign up / login buttons and profile icon button (#51)" This reverts commit e696e03. * about page + stylistic changes * GI: Fixed styling for popup boxes * GI: Fixed checkboxes/dropdown formatting * GI: Fixing tests * GI: Fixed popup box logo sizing --------- Co-authored-by: mahekagg <[email protected]> Co-authored-by: David Li <[email protected]> Co-authored-by: jarenadams21 <[email protected]> Co-authored-by: Chris He <[email protected]> Co-authored-by: David Li <[email protected]> Co-authored-by: Kenny Jung <[email protected]> Co-authored-by: “airman416” <“[email protected]”> Co-authored-by: James Colesanti <[email protected]>
JamesColesanti
pushed a commit
that referenced
this pull request
Nov 9, 2023
* intial commit * initial commit * started sample map * map loads 0726 * added boundary feature and restrictions * map renders without api key in index file * WIP * cleaned up the code * revert changes to monarch * remove whitespace * removed marker * added comments * WIP * WIP * added marker functionality * added constants file * search box * removed ts-ignore + fixed errors * removed ts-ignore + fixed errors * fixed lint errors * added places library to loader * added setup instructions to readme * added setup instructions to readme * added gi locations for markers * initial commit * added divider and about * added header and MapLegend component * added header * fixed double map * WIP * fixed positioning * created legend icons array * added checkboxes and site type icons * created map page * create popup box * completed navbar * removed unnecessary functions * code cleanup * addressed comments * popup box renders for all markers * finished styling popup box * Revert "Hm popup box" * fix page * WIP * file name update * fixed * fixed popup box * fixed styling * fixed styling * added image files * created selectable buttons and attempted collapse * working on collapse * add sites from google sheets * icons * added site types * add custom icons * filtering works for feature types! * filtering by feature type * everything but font' * revert accidental main commit * WIP * GI-5 Make legend box fully collapsible (#46) * collapsible legend, not great styling * button within same component, no size flicker * removed empty tag render * change appbar position type (#39) * 37 gi 6 make search box customizable (#47) * Comment out links to the events and FAQ pages in the footer (#34) * change searchbox dimensions + rounded corners * Changed font * resolve merge, revert footer --------- Co-authored-by: Kenny Jung <[email protected]> Co-authored-by: “airman416” <“[email protected]”> Co-authored-by: Hamsini Malli <[email protected]> * add sites + filtering by status & feature works * repositioned map icons * restored collapsible box * ui changes in progress * updated icons * cleaned code * meeting changes (#52) Co-authored-by: David Li <[email protected]> * GI-9 Add sign up / login buttons and profile icon button (#51) * stash changes before merge * update styling * remove comments * GI-10 add checkboxes next to "Available" / "Adopted" (#56) * status checkboxes * remove unused comments * update styling * remove unused arg * change checkbox color * Removed import --------- Co-authored-by: “airman416” <“[email protected]”> * GI-10 Add "Available"/"Adopted" checkboxes (v2) (#57) * status checkboxes * remove unused comments * update styling * remove unused arg * change checkbox color * Removed import * revert version * actually fixed fr --------- Co-authored-by: “airman416” <“[email protected]”> * Revert "GI-10 Add "Available"/"Adopted" checkboxes (v2) (#57)" This reverts commit bbaa240. * Revert "GI-10 add checkboxes next to "Available" / "Adopted" (#56)" This reverts commit e19c03f. * Revert "GI-9 Add sign up / login buttons and profile icon button (#51)" This reverts commit e696e03. * about page + stylistic changes * GI: Fixed styling for popup boxes * GI: Fixed checkboxes/dropdown formatting * GI: Fixing tests * GI: Fixed popup box logo sizing * most changes --------- Co-authored-by: Hamsini Malli Sivakumar <[email protected]> Co-authored-by: unknown <[email protected]> Co-authored-by: mahekagg <[email protected]> Co-authored-by: jarenadams21 <[email protected]> Co-authored-by: Chris He <[email protected]> Co-authored-by: Kenny Jung <[email protected]> Co-authored-by: “airman416” <“[email protected]”> Co-authored-by: James Colesanti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #50
📝 Description
Write a short summary of what you added. Why is it important? Any member of C4C should be able to read this and understand your contribution -- not just your team members.
This PR matches the legend design for the dropdown in figma, to the one in the application. David and I used material UI icons for the caret, and used direct values for colors and spacing reflected in the figma.
Briefly list the changes made to the code:
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
🏕️ (Optional) Future Work / Notes
Not a lot of future work needed here. Just two things: