Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crmsh-4.6] Dev: bootstrap: Option -N should require option -y #1657

Open
wants to merge 2 commits into
base: crmsh-4.6
Choose a base branch
from

Conversation

liangxin1300
Copy link
Collaborator

backport #1656

To avoid potential misconfiguration between nodes on interactive mode.

e.g. Specify multiple interfaces on local node, but the peer node don't
know the configuration.
@liangxin1300 liangxin1300 force-pushed the 20250106_option_N_require_y_crmsh46 branch from 2a6fe6a to ab64d73 Compare January 6, 2025 03:29
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.86%. Comparing base (f5b1328) to head (ab64d73).

Additional details and impacted files
Flag Coverage Δ
integration 52.65% <100.00%> (+<0.01%) ⬆️
unit 49.40% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/bootstrap.py 84.56% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 requested a review from zzhou1 January 6, 2025 04:52
@liangxin1300 liangxin1300 marked this pull request as ready for review January 6, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant