Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/#49 follow api #52

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Feat/#49 follow api #52

wants to merge 3 commits into from

Conversation

juuuuone
Copy link
Contributor

πŸ“Œ μ—°κ΄€ 이슈

🌱 PR μš”μ•½

  • νŒ”λ‘œμš°/μ–ΈνŒ”λ‘œμš° api κ΅¬ν˜„
  • νŒ”λ‘œμš° 쑰회 api κ΅¬ν˜„

πŸ›  μž‘μ—… λ‚΄μš©

  • νŒ”λ‘œμš°/μ–ΈνŒ”λ‘œμš° api λŠ” ν•˜λ‚˜λ‘œ ν†΅ν•©λ¨μœΌλ‘œμ¨, ν˜ΈμΆœμ‹œλ§ˆλ‹€ κΈ°μ‘΄μƒνƒœμ—μ„œ λ³€κ²½λ©λ‹ˆλ‹€.
    (였λ₯˜ κ°€λŠ₯μ„± : νŒ”λ‘œμš°μ•„μ΄λ””/νŒ”λ‘œμž‰ 아이디λ₯Ό κ°™μ€κ±Έλ‘œ μž…λ ₯ν–ˆμ„λ•Œ, μ—†λŠ” 아이디λ₯Ό μž…λ ₯ν–ˆμ„λ•Œ)
  • νŒ”λ‘œμš° 쑰회 apiλ₯Ό κ΅¬ν˜„ν–ˆμŠ΅λ‹ˆλ‹€.
    (였λ₯˜ κ°€λŠ₯μ„± : μ—†λŠ” 아이디λ₯Ό μž…λ ₯ν–ˆμ„λ•Œ)

πŸ“Έ μŠ€ν¬λ¦°μƒ·

<νŒ”λ‘œμš°/μ–ΈνŒ”λ‘œμš°>
image
image
image

<νŒ”λ‘œμš° 쑰회>
image
image

β—οΈλ¦¬λ·°μ–΄λ“€κ»˜

  • κΈ°μ‘΄ κ΅¬ν˜„ν•œ μ„œλΉ„μŠ€μ—μ„œ νŠΈλžœμž­μ…˜μ΄ ν•„μš”ν•œ λΆ€λΆ„λ“€ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

@juuuuone juuuuone added ✨ Feat New feature or request ♻️ Refactor Extra attention is needed labels Jan 17, 2025
@juuuuone juuuuone linked an issue Jan 17, 2025 that may be closed by this pull request
[feat] νŒ”λ‘œμš° κ΅¬ν˜„ #49
Open
@youngJun99 youngJun99 self-requested a review January 18, 2025 07:04
youngJun99
youngJun99 approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@youngJun99 youngJun99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜κ³ ν•˜μ…¨μ–΄μš”!

src/main/java/com/clokey/server/domain/member/api/MemberRestController.java
MemberDTO.FollowRP response= followCommandService.followCheck(request);

return BaseResponse.onSuccess(SuccessStatus.MEMBER_SUCCESS, response);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μΈμŠ€νƒ€κ·Έλž¨ 처럼 νšŒμ›μ„ μ‘°νšŒν•  경우 νŒ”λ‘œμš°λ₯Ό ν•˜κ³  μžˆλŠ”μ§€ μ•Œμ•„μ•Ό ν•  것 κ°™μ•„μš”.
λ”°λΌμ„œ, νšŒμ› 쑰회 API의 Response에 "isFollowing"κ³Ό 같이 νŒ”λ‘œμš° 쀑인지 정보λ₯Ό λ˜μ Έμ£Όμ–΄μ•Ό ν•  것 κ°™μ•„μš”!

μ΄λŠ” μƒˆλ‘œμš΄ APIκ°€ μ•„λ‹Œ νšŒμ› μ‘°νšŒμ— μš°μ„ μ μœΌλ‘œ μΆ”κ°€κ°€ λ˜μ–΄μ•Ό ν•œλ‹€κ³  μƒκ°ν•©λ‹ˆλ‹€!

  1. νšŒμ›μ„ μ‘°νšŒν•˜λ©΄ νŒ”λ‘œμš° 정보가 λ– μ•Ό ν•˜κΈ° λ•Œλ¬Έμ— νšŒμ› 쑰회 API에 isFollowing을 μΆ”κ°€μ μœΌλ‘œ μ•Œλ €μ€˜μ•Όν•¨.
  2. νšŒμ› 쑰회 -> νŒ”λ‘œμš° κΈ°λŠ₯이 ν˜ΈμΆœλ˜λŠ” μˆœμ„œλ‘œ μ§„ν–‰λ˜κΈ° λ•Œλ¬Έμ— νŒ”λ‘œμš°APIμ—μ„œ isFollowing의 정보λ₯Ό 받도둝 ν•  수 μžˆλ‹€.
  3. isFollowing의 정보λ₯Ό λ°”νƒ•μœΌλ‘œ νŒ”λ‘œμš° μƒνƒœλ₯Ό λ³€ν™˜ν•œλ‹€(λ ˆν¬μ§€ν† λ¦¬λ₯Ό 보고 νŒ”λ‘œμš° 정보λ₯Ό 확인 ν•˜λ˜ 뢀뢄은 κ²€μ¦μœΌλ‘œ λŒ€μ²΄).

Ssamssamukja
Ssamssamukja approved these changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@Ssamssamukja Ssamssamukja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€

src/main/java/com/clokey/server/domain/member/dto/MemberDTO.java
import lombok.AllArgsConstructor;
import lombok.Builder;
import lombok.Getter;
import lombok.NoArgsConstructor;

import java.time.LocalDateTime;

public class MemberResponseDTO {
public class MemberDTO {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MemberResponseDTOμ—μ„œ μˆ˜μ •ν•˜μ‹  μ΄μœ κ°€ μžˆμ„κΉŒμš”??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngJun99 youngJun99 youngJun99 approved these changes

@Ssamssamukja Ssamssamukja Ssamssamukja approved these changes

Assignees
No one assigned
Labels
♻️ Refactor Extra attention is needed ✨ Feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] νŒ”λ‘œμš° κ΅¬ν˜„
3 participants
@juuuuone @Ssamssamukja @youngJun99