Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove database-related functions from schug #63

Closed
wants to merge 5 commits into from

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Feb 5, 2024

This PR adds | fixes:

  • Database functionality is not currently used for repo, so remove it for the time being.
  • This is fixing a rather important bug in scout due to the fact that this repo has to co-exist with chanjo and chanjo-report, which instead use SQL (unfortunately a very old lib that has a conflict with the lib used here)

How to test:

  • Automatic tests should pass
  • Deploy on cg-vm1 stage and make sure you can download genes, transcripts and exons as you do using main branch

Review:

  • Code approved by
  • Tests executed by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@northwestwitch northwestwitch marked this pull request as draft February 5, 2024 17:39
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant