Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CI to GitHub Actions #175

Merged
merged 14 commits into from
Jul 31, 2024
Merged

Move CI to GitHub Actions #175

merged 14 commits into from
Jul 31, 2024

Conversation

samuell
Copy link
Contributor

@samuell samuell commented Jun 28, 2024

Description

This PR moves the CI workflow configuration from the previous Travis CI one to GitHub actions, as suggested in #174

Some more details of changes done:

  • The install script uses micromamba instead of conda if inside GitHub actions
  • Some dependency specs were adjusted to make the installation go through
  • A pointer to a folder ${CONDA_PREFIX}/testproject was changed to ${CONDA_PREFIX}/testdata instead, since the former does not exist in the repo.
  • Two smaller bugs identified by flake8 was fixed, along with a typo

You can check the output of the converted code on the actions tab of this repo.

Primary function of PR

  • Hotfix
  • Patch
  • Minor functionality improvement
  • New type of analysis
  • Backward-breaking functionality improvement
  • This change requires internal documents to be updated
  • This change requires another repository to be updated

Testing

If the update is a hotfix, it is sufficient to rely on the development testing along with the Travis self-test automatically applied to the PR.

Test routine to verify the stability of the PR:

  • bash /home/proj/production/servers/resources/hasta.scilifelab.se/install-microsalt-stage.sh BRANCHNAME
  • us
  • conda activate S_microSALT
  • (SITUATIONAL) export MICROSALT_CONFIG=/home/proj/dropbox/microSALT.json
  • Select a relevant subset of the following:
  • microSALT analyse project MIC3109
  • microSALT analyse project MIC4107
  • microSALT analyse project MIC4109
  • microSALT analyse project ACC5551

Verify that the results for projects MIC3109, MIC4107, MIC4109 & ACC5551 are consistent with the results attached to AMSystem doc 1490, Microbial_WGS.xlsx

Test results

These are the results of the tests, and necessary conclusions, that prove the stability of the PR.

Sign-offs

@samuell samuell force-pushed the 174-move-ci-to-gha branch 10 times, most recently from ea4658a to 914d050 Compare July 4, 2024 15:20
@samuell samuell force-pushed the 174-move-ci-to-gha branch from 914d050 to fd6fbcc Compare July 4, 2024 15:23
@samuell samuell marked this pull request as ready for review July 4, 2024 15:48
@samuell samuell requested a review from a team as a code owner July 4, 2024 15:48
@samuell
Copy link
Contributor Author

samuell commented Jul 4, 2024

I haven't successfully tested the installation on Hasta Stage yet, since it seems to break on some unrelated things (can not find databases etc).

I might need to discuss with some of you on how to best test this on Hasta.

@samuell samuell assigned samuell and unassigned samuell Jul 4, 2024
Copy link
Contributor

@Vince-janv Vince-janv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

microSALT/cli.py Show resolved Hide resolved
@samuell samuell linked an issue Jul 12, 2024 that may be closed by this pull request
@karlnyr karlnyr changed the base branch from master to rc400 July 31, 2024 08:25
@karlnyr karlnyr merged commit f2fefcf into rc400 Jul 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch CI from TravisCI to GitHub Actions
3 participants