-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CI to GitHub Actions #175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuell
force-pushed
the
174-move-ci-to-gha
branch
10 times, most recently
from
July 4, 2024 15:20
ea4658a
to
914d050
Compare
samuell
force-pushed
the
174-move-ci-to-gha
branch
from
July 4, 2024 15:23
914d050
to
fd6fbcc
Compare
I haven't successfully tested the installation on Hasta Stage yet, since it seems to break on some unrelated things (can not find databases etc). I might need to discuss with some of you on how to best test this on Hasta. |
Vince-janv
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the CI workflow configuration from the previous Travis CI one to GitHub actions, as suggested in #174
Some more details of changes done:
${CONDA_PREFIX}/testproject
was changed to${CONDA_PREFIX}/testdata
instead, since the former does not exist in the repo.You can check the output of the converted code on the actions tab of this repo.
Primary function of PR
Testing
If the update is a hotfix, it is sufficient to rely on the development testing along with the Travis self-test automatically applied to the PR.
Test routine to verify the stability of the PR:
bash /home/proj/production/servers/resources/hasta.scilifelab.se/install-microsalt-stage.sh BRANCHNAME
us
conda activate S_microSALT
export MICROSALT_CONFIG=/home/proj/dropbox/microSALT.json
microSALT analyse project MIC3109
microSALT analyse project MIC4107
microSALT analyse project MIC4109
microSALT analyse project ACC5551
Verify that the results for projects MIC3109, MIC4107, MIC4109 & ACC5551 are consistent with the results attached to AMSystem doc 1490, Microbial_WGS.xlsx
Test results
These are the results of the tests, and necessary conclusions, that prove the stability of the PR.
Sign-offs