Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify genes table converting the ensembl_id string field to ensembl_ids: an array of strings #394

Merged
merged 19 commits into from
Jan 16, 2025

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Jan 15, 2025

Description

Added/Changed/Fixed

How to test

  • Automatic tests
  • Deploy on stage server and run different tests for the reports

Expected outcome

  • All reports should return the same values as on main branch

Review

  • Tests executed by CR
  • "Merge and deploy" approved by

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@northwestwitch northwestwitch marked this pull request as ready for review January 15, 2025 14:07
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 62.96296% with 20 lines in your changes missing coverage. Please review.

Project coverage is 92.22%. Comparing base (6fcdf37) to head (1e1eafa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/chanjo2/meta/handle_d4.py 30.76% 18 Missing ⚠️
src/chanjo2/crud/intervals.py 90.90% 1 Missing ⚠️
src/chanjo2/meta/handle_load_intervals.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
- Coverage   92.60%   92.22%   -0.38%     
==========================================
  Files          31       31              
  Lines        1514     1531      +17     
==========================================
+ Hits         1402     1412      +10     
- Misses        112      119       +7     
Flag Coverage Δ
unittests 92.22% <62.96%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@northwestwitch northwestwitch added Bug Something isn't working Effort M Effort medium Enhancement New feature or request Refactor task labels Jan 15, 2025
@northwestwitch
Copy link
Member Author

northwestwitch commented Jan 16, 2025

Testing this PR on stage:

  • Drop the old database
  • Create a new database
  • Populate genes (build 37)
image
  • Populate transcripts (build 37)
image
  • Populate exons (build 37)
image
  • Create coverage report using a gene panel from scout

Main branch:

image

This branch:

image
  • Create a panel coverage overview
image
  • Create a gene coverage overview

Main branch:

image

This branch:

image
  • All reports should contain the same stats as before the change in the database

@northwestwitch northwestwitch merged commit 684dcab into main Jan 16, 2025
8 checks passed
@northwestwitch northwestwitch deleted the fix_mysql_create_tables branch January 16, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Effort M Effort medium Enhancement New feature or request Refactor task
Projects
None yet
2 participants