Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified intervals endpoint to return complete info on genes, transcripts and exons #384

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Oct 29, 2024

Description

Added/Changed/Fixed

How to test

  • Locally, use the intervals endpoint to return genes, transcripts, exons

Expected outcome

  • SQL intervals should be returned as they are

Review

  • Tests executed by CR
  • "Merge and deploy" approved by

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Copy link

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (719f1b8) to head (5262c88).
Report is 145 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
+ Coverage   90.18%   92.60%   +2.41%     
==========================================
  Files          30       31       +1     
  Lines        1457     1514      +57     
==========================================
+ Hits         1314     1402      +88     
+ Misses        143      112      -31     
Flag Coverage Δ
unittests 92.60% <100.00%> (+2.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@northwestwitch northwestwitch marked this pull request as ready for review October 29, 2024 08:52
@northwestwitch
Copy link
Member Author

Genes endpoint

Main branch

image

This branch

image

Transcripts endpoint

Main branch - was already OK

image

This branch

image

Exons endpoint

Main branch

image

This branch

image

@northwestwitch northwestwitch merged commit 5a90832 into main Oct 29, 2024
7 checks passed
@northwestwitch northwestwitch deleted the complete_intervals_info branch October 29, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify genes, transcripts, exons endpoints to return complete info
2 participants