Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorted intervals into d4 functions #358

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Sep 27, 2024

Description

Added/Changed/Fixed

How to test

  • Deploy on stage and check with a scout case, both report/overview and gene page

Expected outcome

  • All pages should work

Review

  • Tests executed by CR
  • "Merge and deploy" approved by

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@northwestwitch northwestwitch marked this pull request as draft September 27, 2024 08:50
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.26%. Comparing base (719f1b8) to head (7338d07).
Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
src/chanjo2/meta/handle_d4.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
+ Coverage   90.18%   91.26%   +1.07%     
==========================================
  Files          30       31       +1     
  Lines        1457     1476      +19     
==========================================
+ Hits         1314     1347      +33     
+ Misses        143      129      -14     
Flag Coverage Δ
unittests 91.26% <85.71%> (+1.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@northwestwitch northwestwitch marked this pull request as ready for review September 27, 2024 09:31
@northwestwitch
Copy link
Member Author

Report 🆗

image

Overview 🆗

image

Gene 🆗

image

@northwestwitch northwestwitch merged commit 738e34a into main Sep 27, 2024
7 checks passed
@northwestwitch northwestwitch deleted the sorted_intervals_into_d4_functions branch October 8, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle the fact that d4tools sorts intervals by chrom, start and stop when calculating coverage
2 participants