Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New EPP: Calculate ABC Reagent Volumes for Revio Sequencing #583

Merged
merged 8 commits into from
Jan 24, 2025

Conversation

idalindegaard
Copy link
Contributor

Added

  • New EPP Revio ABC Volumes

Changed

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@idalindegaard
Copy link
Contributor Author

idalindegaard commented Jan 23, 2025

Testing on stage

EPP: Calculate Revio ABC Volumes

bash -c -l "conda activate cg_lims &&  lims -c /home/glsai/.genologics.yaml epps -l {compoundOutputFileLuid0} -p {processLuid} udf calculate revio-abc-volumes -v 'Volume (ul)' --factor 1.1 --annealing-reagent-ratio 0.5 --polymerase-buffer-ratio 1.88 --polymerase-dilution-mix-ratio 2 --sequencing-polymerase-ratio 0.12"

Volume ratios and calculations are seen in the table below
Screenshot 2025-01-23 at 11 53 13

Volumes were successfully calculated and updated.
Screenshot 2025-01-23 at 12 01 43

Error message when missing a value for Volume (ul):
Screenshot 2025-01-23 at 12 05 13

EPP works successfully!

@idalindegaard
Copy link
Contributor Author

Disclaimer: will remove stuff that's not needed in the step anymore :)

Copy link
Collaborator

@Karl-Svard Karl-Svard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice Ida! You've written a nice and concise script for a complex problem with several calculations and UDFs being set. I have some ideas that popped into my head, feel free to disregard them if you don't agree!

cg_lims/EPPs/udf/calculate/revio_abc_volumes.py Outdated Show resolved Hide resolved
cg_lims/EPPs/udf/calculate/revio_abc_volumes.py Outdated Show resolved Hide resolved
@idalindegaard idalindegaard merged commit 6366dbd into master Jan 24, 2025
2 checks passed
@idalindegaard idalindegaard deleted the calculate_abc_volumes branch January 24, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants