Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer file2udf_quantit_qc to cg_lims #574

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

Karl-Svard
Copy link
Collaborator

Added

  • New EPP, cg_lims/EPPs/files/parsers/quantit_excel_to_udf.py
  • New common functions in cg_lims/get/fields.py
  • New common functions in cg_lims/get/artifacts.py

Changed

  • Moved all parser EPPs into a common subdir, cg_lims/EPPs/files/parsers
  • Refactored the CSV parser slightly, cg_lims/EPPs/files/parsers/file_to_udf.py

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@Karl-Svard
Copy link
Collaborator Author

New EPP created in stage

1. Get Concentration from Result File (NEW)

bash -c -l "conda activate cg_lims && lims -c /home/glsai/.genologics.yaml epps -l {compoundOutputFileLuid0} -p {processLuid} files quantit-excel-to-udf --udf 'Concentration' --file 'Quantit Result File'"

Tests compared to the old script

Old success:
Screenshot 2025-01-09 at 12 11 25

New success:
Screenshot 2025-01-09 at 12 10 46

Old fail:
Screenshot 2025-01-09 at 12 15 50

New fail:
Screenshot 2025-01-09 at 12 16 07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants