feat: Redesign the landing page #401
Conversation
for more information, see https://pre-commit.ci
|
Looks good! Very excited for this. Just a note:
Other than that, I'll leave it up to you @dmlb to approve/merge this since I think you have more idea of what's going on in the code here :) |
| > | ||
| <DarkModeControl cssClass="w-fit p-2"></DarkModeControl> | ||
|
|
||
| <button on:click={handleDropdownClick} id="menu"> |
There was a problem hiding this comment.
one thing missing here, we need an accessible name for this menu button
| <a href="{base}/resources" class="heroCardContainer"> | ||
| <div class="heroCard"> | ||
| <div class="relative"> | ||
| <img |
There was a problem hiding this comment.
we should circle back around later with some avif options 🚀
| or | ||
| <a href={github_url} class="underline">edit on GitHub directly</a> | ||
| <div class="max-w-7xl mx-auto"> | ||
| <h1 class="font-bold text-5xl mx-6"> |
There was a problem hiding this comment.
design wise on mobile, looks like the headings should shrink some for that context
| {#if href} | ||
| <a | ||
| {href} | ||
| class="ctaBtn bg-transparent hover:bg-blue-tertiary text-white py-2 px-4 rounded-full mx-6 sm:mr-6" |
There was a problem hiding this comment.
for consistency with the tailwind usage and buttons, if you have the time to turn button class into something global with tailwind's @apply?
example:
.button {
@apply bg-transparent hover:bg-blue-tertiary text-white border border-current py-2 px-4 rounded-full mx-6 sm:mr-6;
}
| } | ||
|
|
||
| .ctaBtn:focus-visible { | ||
| box-shadow: 0 0 0 8px theme("colors.blue-primary"); |
There was a problem hiding this comment.
both the hover and the box-shadow currently match the background of the only use case and can't see any feedback changes from these styles 😅
Screen.Recording.2024-08-21.at.4.28.30.PM.mov
if the goal is just the size shift -- using transform: scale would be more performant
Describe your changes
Updated the landing page to match the Figma Redesign which is referenced in #70.
Related issue number/link
Fixes #385