Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin gcc 9 and 11 workflows to 22.04 #78894

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

akrieger
Copy link
Member

@akrieger akrieger commented Jan 1, 2025

Summary

None

Purpose of change

github is moving ubuntu-latest to 24.04, and our workflows use older gccs which aren't on it. actions/runner-images#10636

Describe the solution

Pin to 22.04 which does have the compilers per the linked issue.

Describe alternatives you've considered

Testing

Additional context

@akrieger akrieger marked this pull request as ready for review January 1, 2025 23:52
@github-actions github-actions bot added Code: Tooling Tooling that is not part of the main game but is part of the repo. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 1, 2025
@moxian
Copy link
Contributor

moxian commented Jan 2, 2025

Would we perhaps want to update our workflows to use newer versions of gcc?

If not, what would be the blockers, and is there understanding of how long we're going to stay pinned on 22.04?

Or is this simply a temporary bandaid to prevent immediate workflow breakage (while we migrate to 24.04/new latest)?

@harakka
Copy link
Member

harakka commented Jan 2, 2025

@bearycool11 are you sure you're in the right place? You don't have merge permissions on this repository, so merging will be blocked for you.

@akrieger
Copy link
Member Author

akrieger commented Jan 2, 2025

Would we perhaps want to update our workflows to use newer versions of gcc?

If not, what would be the blockers, and is there understanding of how long we're going to stay pinned on 22.04?

Or is this simply a temporary bandaid to prevent immediate workflow breakage (while we migrate to 24.04/new latest)?

The workflows should always use pinned workers, there must have been some reason they used ubuntu-latest before. However no, the goal isn't to support the latest and greatest always, it's to validate that the default compiler available on the various supported distros works out of the box so people don't have to go out of their way to install a newer one.

@moxian
Copy link
Contributor

moxian commented Jan 2, 2025

That's reasonable!

A bit too late, but I've finally found that we do have the docs on the subject of compiler support: https://github.com/CleverRaven/Cataclysm-DDA/blob/master/doc/COMPILING/COMPILER_SUPPORT.md

It sounds like we do still want to support gcc-9 until it Ubuntu Focal / Debain Bullseye go EoL (Apr 2025 and Aug 2026 respectively), so that makes sense!

However, the gcc-11 is a tad bit more puzzling, I feel. To me it seems that there is little reason to run a random slightly-old version which is neither "minimum supported (gcc-9)" nor a "reasonably latest". At a cursory search it appears that gcc-11 is only really "supported" by the aforementioned Debian/Ubuntu releases, and all the other distros i've looked at (Gentoo, Fedora, Arch) either have support for a much newer one, or are terribly outdated and don't even have gcc-9 (CentOS with gcc-8).

Do we perhaps want to explicitly un-pin the gcc-11 runner and instead bump its version to the latest-and-greatest (gcc-14)? After all, it would be weird if we couldn't build the project on the Ubuntu 24.04...

@akrieger
Copy link
Member Author

akrieger commented Jan 2, 2025

Maybe, but that's worth a separate pr.

@kevingranade kevingranade merged commit 87fe0a2 into CleverRaven:master Jan 2, 2025
25 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants