-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin gcc 9 and 11 workflows to 22.04 #78894
Conversation
Would we perhaps want to update our workflows to use newer versions of gcc? If not, what would be the blockers, and is there understanding of how long we're going to stay pinned on 22.04? Or is this simply a temporary bandaid to prevent immediate workflow breakage (while we migrate to 24.04/new latest)? |
@bearycool11 are you sure you're in the right place? You don't have merge permissions on this repository, so merging will be blocked for you. |
The workflows should always use pinned workers, there must have been some reason they used ubuntu-latest before. However no, the goal isn't to support the latest and greatest always, it's to validate that the default compiler available on the various supported distros works out of the box so people don't have to go out of their way to install a newer one. |
That's reasonable! A bit too late, but I've finally found that we do have the docs on the subject of compiler support: https://github.com/CleverRaven/Cataclysm-DDA/blob/master/doc/COMPILING/COMPILER_SUPPORT.md It sounds like we do still want to support gcc-9 until it Ubuntu Focal / Debain Bullseye go EoL (Apr 2025 and Aug 2026 respectively), so that makes sense! However, the gcc-11 is a tad bit more puzzling, I feel. To me it seems that there is little reason to run a random slightly-old version which is neither "minimum supported (gcc-9)" nor a "reasonably latest". At a cursory search it appears that gcc-11 is only really "supported" by the aforementioned Debian/Ubuntu releases, and all the other distros i've looked at (Gentoo, Fedora, Arch) either have support for a much newer one, or are terribly outdated and don't even have gcc-9 (CentOS with gcc-8). Do we perhaps want to explicitly un-pin the gcc-11 runner and instead bump its version to the latest-and-greatest (gcc-14)? After all, it would be weird if we couldn't build the project on the Ubuntu 24.04... |
Maybe, but that's worth a separate pr. |
Summary
None
Purpose of change
github is moving ubuntu-latest to 24.04, and our workflows use older gccs which aren't on it. actions/runner-images#10636
Describe the solution
Pin to 22.04 which does have the compilers per the linked issue.
Describe alternatives you've considered
Testing
Additional context