Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using a
clevercloud_docker
resource, environment variables are automatically added to the Docker App.For example, with the following simple code :
The following env-vars are automatically added by the provider :
The
CC_DOCKER_FIXED_CIDR_V6
is set tofalse
, as it should be a CIDR.This bad configuration prevents applications to start with the following logs :
This issue as already been found in #87.
workaround
To address this issue, overriding the environment variable with
null
in the Terraform configuration works, but is an ugly workaround :By doing so, the provider doesn't set the environment variable
best solution
It seems that the argument named
enable_ipv6
is named badly, or does not work as expected.I'm not sure whether this argument should be renamed or if the underlying code should be rewritten, but this will need some work
proposed solution
This PR proposes to simply remove the default values for arguments that occur an env var to be set, so no defaut env var is added.
This will allow the simple use-cases to work, and will also allow these values to be set.
This works well as the provider code checks wether the argument has a value before addin the env var :