Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logs): show addon logs when addonId is provided #681

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Conversation

miton18
Copy link
Contributor

@miton18 miton18 commented Feb 13, 2024

No description provided.

@miton18 miton18 requested a review from a team as a code owner February 13, 2024 11:01
Copy link
Member

@hsablonniere hsablonniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @miton18, thanks for this!!

You changed the color in the same commit, that's OK but I almost missed. I added a suggestion but it's not blocking, feel free to apply it or not and merge + release!

src/commands/logs.js Outdated Show resolved Hide resolved
src/commands/logs.js Outdated Show resolved Hide resolved
Copy link
Member

@hsablonniere hsablonniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last question, sorry.

src/commands/logs.js Outdated Show resolved Hide resolved
Copy link
Member

@hsablonniere hsablonniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@miton18 miton18 merged commit 268d3c5 into master Feb 14, 2024
3 of 5 checks passed
@miton18 miton18 deleted the fix/addon-logs branch February 14, 2024 13:11
Copy link

🔎 The preview has been automatically deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants