Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(applications): use current directory as default create name #634

Merged
merged 2 commits into from
Feb 16, 2024
Merged

feat(applications): use current directory as default create name #634

merged 2 commits into from
Feb 16, 2024

Conversation

davlgd
Copy link
Contributor

@davlgd davlgd commented Nov 22, 2023 •
edited
Loading

Fix #616

@davlgd davlgd requested a review from a team as a code owner November 22, 2023 11:05
@davlgd davlgd self-assigned this Nov 22, 2023
@davlgd davlgd changed the title Use current directory as default name for app creation feat: use current directory as default name for app creation Dec 28, 2023
@davlgd davlgd changed the title feat: use current directory as default name for app creation feat (applications): use current directory as default create name Dec 28, 2023
@davlgd davlgd mentioned this pull request Jan 2, 2024
Open
@hsablonniere hsablonniere changed the title feat (applications): use current directory as default create name feat(applications): use current directory as default create name Feb 15, 2024
@hsablonniere hsablonniere force-pushed the davlgd-default-name-app-creation branch from f0163af to 92255bb Compare February 15, 2024 17:36
@github-actions GitHub Actions
Copy link

🔎 A preview has been automatically published:

  • 🐧 linux 4aed3d06196a92c59d9f7d6b7cdf059ed934beabc03972c7fbecb7b5ae73650d
  • 🍏 macos 5cafc059c2686a5112237b1679a9ce1a766a79225bf95bad07d2ef5b640f66ee
  • 🪟 win 03eacddde6974c0a11f76cd87240a3b713bad32d281b939a92c26235f8125da6

This preview will be deleted once this PR is closed.

@hsablonniere
Copy link
Member

@davlgd I reworked your commits

  • removed the interactivity, we decided it's a bit too much for this usage
  • we thought the impl of "default is current directory name" should be in the command, not clever.js

This simplifies the code a bit. I kept you as the author 😉

@hsablonniere
Copy link
Member

☑️ I just tested the built preview and it works!

  • create without a name
  • create with an explicit name

@hsablonniere hsablonniere force-pushed the davlgd-default-name-app-creation branch from 92255bb to 1a3eb9e Compare February 16, 2024 08:57
@hsablonniere hsablonniere merged commit 6ac4bd4 into master Feb 16, 2024
6 checks passed
@hsablonniere hsablonniere deleted the davlgd-default-name-app-creation branch February 16, 2024 09:03
@github-actions GitHub Actions
Copy link

🔎 The preview has been automatically deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurrelhebert aurrelhebert aurrelhebert approved these changes

@hsablonniere hsablonniere hsablonniere approved these changes

Assignees

@davlgd davlgd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clever create : optional app name
3 participants
@davlgd @hsablonniere @aurrelhebert