Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deploy): support tag option #599

Merged
merged 1 commit into from
Feb 16, 2024
Merged

feat(deploy): support tag option #599

merged 1 commit into from
Feb 16, 2024

Conversation

aurrelhebert
Copy link
Member

closes #265

@aurrelhebert aurrelhebert requested a review from a team as a code owner August 30, 2023 06:33
@aurrelhebert aurrelhebert linked an issue Aug 30, 2023 that may be closed by this pull request
Add --tag option to clever deploy #265
Closed
@aurrelhebert aurrelhebert force-pushed the 265-add-tag-option-to-clever-deploy branch 2 times, most recently from 3af1a14 to 6b173e1 Compare December 19, 2023 13:38
@aheritier aheritier mentioned this pull request Jan 9, 2024
Closed
@miton18
Copy link
Contributor

miton18 commented Jan 19, 2024 

``owner-api on  master [?] via 🐹 v1.21.5 
❯ ccHead deploy --tag tutu 
Remote git head commit   is 103627a58303b41171629326be1eea5d2218d14c
Current deployed commit  is 103627a58303b41171629326be1eea5d2218d14c
New local commit to push is 1ade5d8cea32ce348218c570125a0701c9f158b8 (from refs/tags/tutu)
Pushing source code to Clever Cloud…
[ERROR] Push rejected because tag already exists. Use "force: true" to override.
`

@miton18
Copy link
Contributor

miton18 commented Jan 19, 2024

isomorphic-git/isomorphic-git#1854

@hsablonniere
Copy link
Member

There's an error with annotated tags. We need a new helper function to unpeel them.

See: https://isomorphic-git.org/docs/en/readTag

@aurrelhebert aurrelhebert force-pushed the 265-add-tag-option-to-clever-deploy branch 5 times, most recently from da965c7 to 2fe7c8b Compare January 19, 2024 15:43
@aurrelhebert aurrelhebert force-pushed the 265-add-tag-option-to-clever-deploy branch from 2fe7c8b to 77af7bb Compare February 1, 2024 09:47
@miton18 miton18 force-pushed the 265-add-tag-option-to-clever-deploy branch from 77af7bb to 7a1aba1 Compare February 16, 2024 09:06
@hsablonniere hsablonniere force-pushed the 265-add-tag-option-to-clever-deploy branch 2 times, most recently from 2aeddb2 to 41dcd84 Compare February 16, 2024 09:23
@github-actions GitHub Actions
Copy link

🔎 A preview has been automatically published:

  • 🐧 linux 0f463bdc06803fad4fd76285bacaa47b8607534674d061b8e75cb060b002ff0d
  • 🍏 macos 8fa029d47627ece6faa2ee82a7ece68d1d34833c2e13a68b5f054603d33433fe
  • 🪟 win 31bc353b93a659a4b8a3db0a2a5f554336216b0f88e6406f32f477cbd1091d49

This preview will be deleted once this PR is closed.

@aurrelhebert aurrelhebert force-pushed the 265-add-tag-option-to-clever-deploy branch from 41dcd84 to 52ea270 Compare February 16, 2024 09:34
hsablonniere
hsablonniere approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@hsablonniere hsablonniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully with:

  • tag
  • annotated tag
  • branch

@hsablonniere hsablonniere merged commit 7ecf87f into master Feb 16, 2024
6 checks passed
@hsablonniere hsablonniere deleted the 265-add-tag-option-to-clever-deploy branch February 16, 2024 10:11
@github-actions GitHub Actions
Copy link

🔎 The preview has been automatically deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsablonniere hsablonniere hsablonniere approved these changes

Assignees

@aurrelhebert aurrelhebert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add --tag option to clever deploy
3 participants
@aurrelhebert @miton18 @hsablonniere