fix: prevent graph lines from showing up behind legend #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtoohey31
force-pushed
the
graph-legend-fix
branch
from
b1bc513 to
bb46448
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1683 +/- ##
===========================================
- Coverage 54.08% 42.21% -11.87%
===========================================
Files 111 111
Lines 17441 17445 +4
===========================================
- Hits 9433 7365 -2068
- Misses 8008 10080 +2072
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ClementTsang
approved these changes
Feb 28, 2025
|
@all-contributors please add @mtoohey31 for code |
|
I've put up a pull request to add @mtoohey31! 🎉 |
ClementTsang
added a commit
that referenced
this pull request
Feb 28, 2025
ClementTsang
added a commit
that referenced
this pull request
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when some entries in a graph's legend are shorter than others, it's possible for the graph lines to show up through the legend. This can be seen in the following screenshot:
This pull request fixes the issue. In terms of how the fix is actually implemented, I'm not that familiar with ratatui so lmk if there's a better way to ensure the legend is fully opaque.
Issue
N/A
Testing
I visually examined the graphs to confirm that the bug no longer appears.
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt)README.md, help menu, doc pages, etc.)