Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: don't duplicate AMD GPU temperature retrieval #1682

Merged
merged 4 commits into from
Feb 23, 2025

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Feb 23, 2025

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

We were pulling the AMD GPU temps twice, so this fixes that. This also avoids checking AMD GPU details if the card is asleep.

This change also capitalizes the first letter of temp labels.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

  • Linux

Looks fine to me:

image
image

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang enabled auto-merge (squash) February 23, 2025 06:04
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 18.66667% with 61 lines in your changes missing coverage. Please review.

Project coverage is 54.14%. Comparing base (f7d070f) to head (5549940).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/collection/amd.rs 4.54% 21 Missing ⚠️
src/collection/temperature/linux.rs 36.36% 21 Missing ⚠️
src/collection/linux/utils.rs 0.00% 18 Missing ⚠️
src/collection.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1682       +/-   ##
===========================================
+ Coverage   42.06%   54.14%   +12.07%     
===========================================
  Files         110      111        +1     
  Lines       17500    17441       -59     
===========================================
+ Hits         7362     9444     +2082     
+ Misses      10138     7997     -2141     
Flag Coverage Δ
macos-14 37.71% <ø> (ø)
ubuntu-latest 56.60% <18.66%> (+12.73%) ⬆️
windows-2019 37.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang merged commit d2177ed into main Feb 23, 2025
37 checks passed
@ClementTsang ClementTsang deleted the no_double_amd_gpu_temps branch February 23, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant