Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate to Rust 2024 edition #1678

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Feb 21, 2025

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

This PR migrates us to Rust 2024 edition. Not too much change needed, thankfully! Most of it is formatting changes, with a tiny bit of actual refactoring. All code/style changes done in #1681, this PR will just now mostly be us changing version values.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang marked this pull request as ready for review February 21, 2025 10:51
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.14%. Comparing base (f7d070f) to head (525affd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1678      +/-   ##
==========================================
+ Coverage   42.06%   42.14%   +0.07%     
==========================================
  Files         110      110              
  Lines       17500    17500              
==========================================
+ Hits         7362     7375      +13     
+ Misses      10138    10125      -13     
Flag Coverage Δ
macos-14 37.71% <ø> (ø)
ubuntu-latest 43.95% <ø> (+0.07%) ⬆️
windows-2019 37.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang
Copy link
Owner Author

Might merge this only after doing a stable release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant