-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename flags.enable_gpu
to flags.disable_gpu
(false
by default)
#1559
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1559 +/- ##
==========================================
+ Coverage 41.39% 41.46% +0.07%
==========================================
Files 114 114
Lines 17839 17837 -2
==========================================
+ Hits 7385 7397 +12
+ Misses 10454 10440 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change, otherwise looks fine.
Note I'll probably change it in the future to have more fine-grained control over what parts to include GPU info, but this is fine for now.
flags.enable_gpu
to flags.disable_gpu
(false
by default)
I wanted to fix the documentation as well, but I would have asked you a ton of questions, so it might be faster if you fix it yourself. If there's anything wrong, just let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. Thanks!
@all-contributors please add @shurizzle for code. |
@shurizzle already contributed before to code |
Description
Rename
flags.enable_gpu
toflags.disable_gpu
and make itfalse
by defaultCloses: #1554