Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support italic text styling #1514

Merged
merged 4 commits into from
Jul 31, 2024
Merged

feature: support italic text styling #1514

merged 4 commits into from
Jul 31, 2024

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Jul 31, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Support italics as a text styling option. For example:

image

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.31%. Comparing base (c77256e) to head (43094f8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1514      +/-   ##
==========================================
+ Coverage   41.28%   41.31%   +0.02%     
==========================================
  Files         113      113              
  Lines       17685    17692       +7     
==========================================
+ Hits         7302     7309       +7     
  Misses      10383    10383              
Flag Coverage Δ
macos-12 36.75% <100.00%> (+0.02%) ⬆️
ubuntu-latest 43.29% <100.00%> (+0.02%) ⬆️
windows-2019 36.92% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang marked this pull request as ready for review July 31, 2024 01:44
@ClementTsang ClementTsang enabled auto-merge (squash) July 31, 2024 01:45
@ClementTsang ClementTsang disabled auto-merge July 31, 2024 01:45
@ClementTsang ClementTsang enabled auto-merge (squash) July 31, 2024 01:45
@ClementTsang ClementTsang merged commit 4b14ccb into main Jul 31, 2024
36 checks passed
@ClementTsang ClementTsang deleted the support_italics branch July 31, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant