feat/MSSDK-2126: Create Primer component without backend integration #457
Conversation
m4tewoosh
changed the base branch from
main
to
feat/MSSDK-2064-psp-routing-primer-connector-phase-1
src/components/UpdatePaymentDetailsPopup/UpdatePaymentDetailsPopup.jsx
Outdated
Show resolved
Hide resolved
| @@ -267,6 +267,15 @@ const UpdatePaymentDetailsPopup = () => { | |||
| const showPayPalWhenAdyenIsReady = () => | |||
| shouldShowAdyen ? !!dropInInstance : true; | |||
|
|
|||
| const adyenProps = { | |||
There was a problem hiding this comment.
you could inline this, no need to keep another variable in the memory
There was a problem hiding this comment.
IMO it looks bad when inlined but sure, can inline it
There was a problem hiding this comment.
i just noticed - i don't think this should be an object. this object will be re-created on each render, causing rerenders down the line
if you pass the props as separate props, the rerender will happen only if any of them changes
src/hooks/usePaymentDropIn.tsx
Outdated
| @@ -0,0 +1,31 @@ | |||
| import { lazy } from 'react'; | |||
There was a problem hiding this comment.
the src/hooks directory is meant to hold only context-agnostic, reusable hooks. this one is very context-specific, as it is used in only one component. please move it next to the component
The general rule is that a file should be placed in a location that is the "smallest" common parent location for all the other files that use it
|
m4tewoosh
merged commit c1b28e6
into
feat/MSSDK-2064-psp-routing-primer-connector-phase-1
m4tewoosh
deleted the
feat/MSSDK-2126-create-primer-component-without-backend-integration
branch
Description
To introduce a
Primercomponent similar to the existingAdyencomponent in the project. Import it using lazy loading. The component will import and initialize@primer-io/checkout-webbut will not be integrated with the backend, resulting in an expected error.