Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSSDK-1480] add new info box for unavailable upgrades & refactor OfferCards #274

Merged
merged 10 commits into from
Nov 27, 2023

Conversation

iwonakulacz
Copy link
Collaborator

Description

  • refactor OfferCard related components
  • rewrite new components to TypeScript
  • add new info box when switch with IMMEDIATE_WITH_TIME_PRORATION algorithm was used

Updates

  • extract OfferCard to OfferSwithCard and OfferMyAccountCard
  • remove unused logic from both components and replace props with data from redux
  • replace the old usage of OfferCard with the new components
  • replace gateway logic with externally managed

Screenshots

Testing

Additional Notes

@iwonakulacz iwonakulacz changed the title Mssdk 1480 new info box [MSSDK-1480] add new info box for unavailable upgrades & refactor OfferCards Aug 1, 2023
@iwonakulacz iwonakulacz marked this pull request as ready for review August 1, 2023 10:37
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

isPriceBoxHidden={isPaused}
isPaused={isPaused}
/>
<OfferMyAccountCard offerId={subItem.offerId} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤠

>
{generateDescription() && (
<DescriptionStyled
dangerouslySetInnerHTML={{ __html: generateDescription() }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok for now, but potentially to be replaced with a separate component to avoid dangereouslySetInnerHTML

<IconComponent />
<SubBoxContentStyled>
<BoxTextStyled
dangerouslySetInnerHTML={{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

kkarasek
kkarasek previously approved these changes Aug 3, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pawelacio pawelacio added the help wanted Extra attention is needed label Nov 24, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jkorczakcleeng jkorczakcleeng merged commit e4cc3f2 into main Nov 27, 2023
@jkorczakcleeng jkorczakcleeng deleted the MSSDK-1480-new-info-box branch November 27, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Development

Successfully merging this pull request may close these issues.

5 participants