Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MixinBooter #275

Merged

Conversation

Ecdcaeb
Copy link
Contributor

@Ecdcaeb Ecdcaeb commented Jan 1, 2025

Update MixinBooter

  1. add Context and IMixinConfigHijacker, supplement the missing method.
  2. Fix @deprecated javadoc
  3. Cast IEarlyMixinLoader and IMixinConfigHijacker when loading Coremod to avoid using reflection
  4. Hardcoded modloader for CLEANROOM
  5. Link the present mod directly to the Loader, as in Fugue. But it does not work with IEarlyMixinLoader.

update mixinbooter
better solutions?
@kappa-maintainer
Copy link
Collaborator

编译没过

@Ecdcaeb
Copy link
Contributor Author

Ecdcaeb commented Jan 17, 2025

@kappa-maintainer
Copy link
Collaborator

fabric上游没这玩意,我也懒得额外合并UniMix或者单独加
反正对于这批新API我是一点想法没有,这事就等rong决定好了

@Rongmario
Copy link
Member

Currently waiting on coremod scanning for Context in this PR.

@Rongmario Rongmario self-assigned this Feb 3, 2025
@kappa-maintainer
Copy link
Collaborator

现在什么情况,该merge吗

@kappa-maintainer kappa-maintainer merged commit ba492db into CleanroomMC:experimental/foundation Feb 14, 2025
1 check passed
@Ecdcaeb Ecdcaeb deleted the update_mixinbooter branch February 15, 2025 09:33
Ecdcaeb added a commit to Ecdcaeb/Cleanroom that referenced this pull request Mar 1, 2025
* Update MixinBooter (CleanroomMC#275)

* update mixinbooter

update mixinbooter

* check if the loader loaded

better solutions?

* updates

* merge CleanroomMC/MixinBooter@d8139da,

* updates

* fixs

* fix

* fix

* fixs

* fixs

* fix

* Bump default mixinbooter version

* Update Mixin

* Add Force X11 option

* Avoid oshi crash on Windows

* Workaround for null crash in Context

* Update Mixin

* Bump lwjglxx

* Update lwjglxx

* Update jline

---------

Co-authored-by: arcade_kappa <gkappa@outlands.top>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants