MVJ-733 Fix areasearch address and district update #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juho-kettunen-nc
force-pushed
the
MVJ-733-fix-address-and-district-update
branch
from
d490511 to
311c717
Compare
|
Rebased over latest develop changes |
|
Noticed a possible bug in implementation, will fix |
|
Unit test would be preferable for the function |
If geometry service had returned a partial result (e.g. only a district) and previous data existed for the missing variable (e.g. only an address), the result would have mistakingly bundled them together.
|
Ready for review again, @henrinie-nc . Will squash when merging |
henrinie-nc
reviewed
Mar 4, 2025
| assert district == district_from_geometry | ||
|
|
||
|
|
||
| @pytest.mark.django_db |
There was a problem hiding this comment.
Is the mark.django_db needed, does this do something with db?
henrinie-nc
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't overwrite existing address and district information with None when geometry data is not provided.