-
Notifications
You must be signed in to change notification settings - Fork 24
433: Display event publisher in event preview #457
433: Display event publisher in event preview #457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so apparently a new HTTP API client (axios) was added here. What is the use case, i.e. what are the advantages of adding a new library vs. using fetch as is done with other API calls here? Do you suggest transitioning to the new library instead?
Yeah, I would suggest we change all the existing fetch requests to use axios. Here's a blog post about some of the pros of using axios: https://blog.logrocket.com/axios-or-fetch-api/ |
Okay, can you give a ballpark figure how long the change should take? Probably not too long, since the function calls are rather similar anyway, or am I mistaken? |
It shouldn't take that long, few hours (2-3). |
Great, I would recommend doing that sooner rather than later, otherwise it is forgotten and we end up with competing ways to call the API in the UI 👍 |
I made a new issue for the other API calls, #466 |
#433
Add publisher information under event actions and under event location for event page.
Added also a rest API client for fetching the publisher's information.
I also refactored and cleaned a bit the event page/event details code.