-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sentry): setup before_send to ignore global id errors by message #461
base: master
Are you sure you want to change the base?
Conversation
KUKKUU-API branch is deployed to platta: https://kukkuu-pr461.api.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-pr461.api.dev.hel.ninja 😆🎉🎉🎉 |
33305b1
to
d4b9074
Compare
NOTE: We may not want to have this feature enabled, because then we cannot follow these "unknown" issues in Sentry. |
24b03ca
to
a45948b
Compare
d4b9074
to
59b5bb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed with @karisal-anders , something like this could be an improvement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the str(exc_value)
change (it's clearer that way) looks ok to me, adding a comment about what the "Unable to parse global ID" error is about, and why it is ok to ignore it (i.e. if it is akin to a 404 but thrown by Graphene, and that we have not found a systematic problem with our system creating such problematic non-parseable global ID values) would add clarity/transparency to this still.
a45948b
to
e3c4e4c
Compare
6be690a
to
72042da
Compare
e3c4e4c
to
bc6e627
Compare
KK-1395. The ignore_messages option in sentry_sdk would be great, but since the Graphene raises a general Exception from invalid global ids, we need to follow the exception message instead of class.
72042da
to
b4706a0
Compare
|
KUKKUU-API branch is deployed to platta: https://kukkuu-pr461.api.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-pr461.api.dev.hel.ninja 😆🎉🎉🎉 |
We looked into this 30.1.2025 and there were still some valid sentry issues related to this, so we should keep following the issue and not merge this PR yet. |
KK-1395.
The ignore_messages option in sentry_sdk would be great, but since the Graphene raises a general Exception from invalid global ids, we need to follow the exception message instead of class.