Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-11315 School search #795

Merged
merged 9 commits into from
Feb 21, 2025
Merged

UHF-11315 School search #795

merged 9 commits into from
Feb 21, 2025

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Feb 19, 2025

UHF-11315

What was done

  • Added getters and setters for additional schools, used in search api index preprocessor.
  • Refactored IsSchool search api preprocessor to extend the similar preprocessor from helfi_react_search module.
  • Changed the preprocessor id to helfi_kasko_content_is_school.
  • Altered the school settings form to provide a textarea where to add the additional schools for school index.
  • Added a documentation of the schools index.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-11315
    • make fresh
  • Run make drush-cr
  • Run make drush-cim to update the School search index settings.

How to test

  • Go to edit the school settings and add 6880, 7048 to the List of additional schools textarea.
    • 6880 = Helsingin yliopiston Viikin normaalikoulu
    • 7048 = Helsingin normaalilyseo
  • After saving the settings, open shell and run drush sapi-c; drush sapi-rt; drush sapi-i; drush cr
  • Check that the schools appear to school search
    • You can switch to "Etsi koulun tiedoilla" view, which makes it easier to find the schools. Use the word: normaali
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go 🦖

@khalima khalima merged commit 562e0a6 into dev Feb 21, 2025
3 checks passed
@khalima khalima deleted the UHF-11315 branch February 21, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants