Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9460 comprehensive school search fallback #542

Merged
merged 4 commits into from
Jan 15, 2024
Merged

UHF-9460 comprehensive school search fallback #542

merged 4 commits into from
Jan 15, 2024

Conversation

rpnykanen
Copy link
Contributor

@rpnykanen rpnykanen commented Jan 11, 2024

UHF-9460

Show correct results on fallback view

What was done

Changed the view to use the elasticsearch data instead of database.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-9460
    • make fresh
  • Run make drush-cr

How to test

  • Make sure the elastic index is working and indexed
  • Open the comprehensive school search in 2 browsers, incognito and non-incognito
    • Disable javascript on one of the browsers
  • Check that the search result count matches on both react-search and fallback view
    • You can do this by checking that the page count matches and the last page has same amount of items
  • Test also with different languages

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes. Otherwise worked well 👍

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now and looks good 🦖

@rpnykanen rpnykanen merged commit 62eef7d into dev Jan 15, 2024
2 checks passed
@rpnykanen rpnykanen deleted the UHF-9460 branch January 15, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants